Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ansible sphinx theme to rtd theme version 0.4.3 #61189

Merged
merged 25 commits into from
Aug 28, 2019
Merged

Update Ansible sphinx theme to rtd theme version 0.4.3 #61189

merged 25 commits into from
Aug 28, 2019

Conversation

samccann
Copy link
Contributor

SUMMARY

Update to the last released version of the upstream sphinx-rtd-theme.
Pull out Ansible-specific sections into a separate files to make future theme updates easier

Fixes #58832

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ADDITIONAL INFORMATION

@samccann samccann added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. docs This issue/PR relates to or includes documentation. affects_2.9 This issue/PR affects Ansible v2.9 labels Aug 22, 2019
@samccann samccann added this to To do in OLD Ansible Documentation via automation Aug 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2019

cc @acozine
click here for bot help

@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Aug 22, 2019
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 22, 2019
@samccann
Copy link
Contributor Author

  • Minify css

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 22, 2019
@samccann samccann changed the title [WIP] Update Ansible sphinx theme to rtd theme version 0.4.3 Update Ansible sphinx theme to rtd theme version 0.4.3 Aug 28, 2019
@samccann samccann removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 28, 2019
@acozine
Copy link
Contributor

acozine commented Aug 28, 2019

Let's merge this work now. We can refine the custom-CSS and re-minify later.

@acozine
Copy link
Contributor

acozine commented Aug 28, 2019

Nice work @samccann!

@acozine acozine merged commit 92d5779 into ansible:devel Aug 28, 2019
@acozine acozine mentioned this pull request Aug 28, 2019
Closed
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@samccann @adharshsrivatsr
Update Ansible sphinx theme to rtd theme version 0.4.3 (ansible#61189)
f49923b 
* update theme.conf, header, footer, etc.
* clean up layout.html
* move large Ansible changes out of theme.css
* maxify theme to help merge
* remove redundancies, fix top nav bar
* add Ansible color to header and left-nav menu
@samccann samccann deleted the sphinx-theme.conf branch September 10, 2019 17:30
@samccann samccann mentioned this pull request Sep 19, 2019
Merged
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@samccann @anas-shami
Update Ansible sphinx theme to rtd theme version 0.4.3 (ansible#61189)
4f69694 
* update theme.conf, header, footer, etc.
* clean up layout.html
* move large Ansible changes out of theme.css
* maxify theme to help merge
* remove redundancies, fix top nav bar
* add Ansible color to header and left-nav menu
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sphinx theme to latest (0.4.3)
3 participants
@samccann @ansibot @acozine